search

solomonkinard / public

Other
5 stars 3 forks source link

Git Blame: Line blame is not aligned properly #12

Closed mingyc closed 1 month ago

mingyc commented 7 months ago

See an example of the file

Screenshot 2024-02-22 at 5 01 49 PM

Environment

The editor ruler is set at the 80th column, and the editor font I am using is Fira Code, which is a monospace font.

Expected Behavior

The line blames by Git Blame extension should render all blames after the ruler.

Actual Behavior

They are not aligned at all.

solomonkinard commented 6 months ago

Your bug report is very thorough. Thank you. I haven't been able to reproduce the issue. I wonder if you have a special setup or human language set, if anyone else is facing the issue., or if it's true for you on all files or different computers.

tobiaskraus commented 5 months ago

I have the same issue in all my files: image

.prettierrc.js extends from another prettier-config in my node_modules (with require). In there is defined: printWidth: 120. Maybe it has sth. to do with it.

solomonkinard commented 5 months ago

I tried to reproduce with the extension that you mentioned. It would be nice to be able to try the extension configuration that you have to see if I can reproduce it that way. It's clear that you might not want to share your extensions, so maybe I could install the top 5 extensions to see if they have any effect. My theory at this point is that one or more other extensions are conflicting.

solomonkinard commented 2 months ago

@tobiaskraus, Your problem might be fixed in 0.2.38, but neither of these issues have been reproduced exactly so far?

@mingyc, Your description may be a different problem with Git Blame, and it's unclear if the bug that you described is fixed in 0.2.38?

solomonkinard commented 1 month ago

It's been a few weeks and without hearing back. Closing this bug due to inability to reproduce without feedback. Thanks.