search

solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
575 stars 110 forks source link

Card Details of Card Emulator types are not internationalized #165

Closed impeeza closed 9 months ago

impeeza commented 9 months ago

On the sub-menu Card Emulator -> Card Details -> Type, the names are not internationalized. may be we can include them on the .c files: image By example, UNDEFINED, in Spanish could be NO DEFINIDO

solosky commented 9 months ago

Hi, I think it's better that do not translate those words, because the card type names are kind of technical terms, I cannot find best words to translation for other languages.

By the way, I have removed the UNDEFINED option in card type selection menu, I think the "UNDEFINED" should not be a option here.

solosky commented 9 months ago

see commit: https://github.com/solosky/pixl.js/commit/7c32404ebecad235d5275799aa2914a63257a253

impeeza commented 9 months ago

Perfect, it's a good approach. closing issue.