search

solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
575 stars 110 forks source link

Small Change #174

Closed impeeza closed 9 months ago

impeeza commented 9 months ago

On the Settings app, the names of the language are retrieved from the definitions variable for 3 of the languages but for Chinese and English are hard-coded. I don´t know if is for design or could be improved with this PR.

Let me know if can be merged.

Thanks a lot for your great work.

solosky commented 9 months ago

Hi sir, the language selection can be re-written with a for loop and read from language Enum, it has benefits that if new language is added. would you please have a try to change to that?

impeeza commented 9 months ago

Will try, hope will figure it soon :D 🥰

impeeza commented 9 months ago

Challenge accepted and hope overcome. #175