solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
592 stars 112 forks source link

Reset device confirmation #207

Closed PonyOny closed 8 months ago

PonyOny commented 8 months ago

I purchased a "Allmiibo" some days ago, I have been updating it to the latest version several times since purchased, I don't know if this is something that only happens to me on my device but the "Top Button" the one that lets you navigate Right/Left/Confirm lots of times when pressing it it goes Left/Right then confirms, I have to be very steddy to press the confirm button without triggering the directions as well, what's the main problem with this, every time I enter the Settings menu and have to go back using the bottom menu item "back to Home" it goes up and resets the device to default state... this is really annoying as I have to go again and configure everything I changed and then cross my fingers this does not happen again when trying to go back to home screen, on other menus it's also annoying but not so much as when it restes de device, my point is, would it be possible to add a second step when you select the reset menu so you have a final confirmation, it would probably happen the same.. pressing Cancel then switching to Confirm.. but maybe you would have a second opportunity... or maybe there is another alternative to navigate back.. some sort of long confirm button press or something similar, I hope I've explained myself.

Thanks.

solosky commented 8 months ago

Hi there, I think you are the first one to report this issue, I don't have any issue when go back to home when in settings APP. Anyway, your suggestion seems reasonable, and I will add a confirmation message box before reset to default settings.

impeeza commented 8 months ago

Sadly it appears to be a hardware issue in the selection wheel, mine started to behave like that before it broke, if your device is on warranty ask for it. After I changed my wheel everything back to normal

MirakelDev commented 8 months ago

as an additional enhancement I'd suggest to change the default selection to cancel instead of confirm of every confirmation dialog to avoid accidental acknowledgement

impeeza commented 8 months ago

Cool.

And the order of cancel accept commit to always accept to the dame side😸

MirakelDev commented 8 months ago

Cool.

And the order of cancel accept commit to always accept to the dame side😸

is there any other order then [confirm] [acknowledge] [cancel] https://github.com/search?q=repo%3Asolosky/pixl.js%20mui_msg_box_set_btn_text&type=code

should this order kept and [cancel] always be focused for multiple choice dialogs?

solosky commented 8 months ago

Sorry, I don't your point, the button should be layout with LEFT, CENTER, RIGHT you can call mui_msg_box_set_btn_focus(app->p_msg_box, 0|1|2) set default focus icon.

MirakelDev commented 8 months ago

Sorry, I don't your point, the button should be layout with LEFT, CENTER, RIGHT you can call mui_msg_box_set_btn_focus(app->p_msg_box, 0|1|2) set default focus icon.

yes, that's what i tried to explain: LEFT = confirm like here CENTER = acknowledge like here RIGHT = cancel like here I haven't found any other order than this

For multiple choice dialogs (confirm / cancel) confirm is focused. My question is: Should focus changed to cancel to not accidentally confirm the dialog.

solosky commented 8 months ago

That's exactly order what I have done here. No CENTER button is required here.

mui_msg_box_set_btn_text(app->p_msg_box, _T(CONFIRM), NULL, _T(CANCEL));
mui_msg_box_set_btn_focus(app->p_msg_box, 2);
MirakelDev commented 8 months ago

That's exactly order what I have done here. No CENTER button is required here.

mui_msg_box_set_btn_text(app->p_msg_box, _T(CONFIRM), NULL, _T(CANCEL));
mui_msg_box_set_btn_focus(app->p_msg_box, 2);

yes but should the focus for all other dialogs (confirm/cancel) also be changed to 2?

solosky commented 8 months ago

That's a good question here, my short answer is that the default action should carefully select by its senario. For example, create new folder, the default button should be confirm, but for delete action, the default action should be cancel.

MirakelDev commented 8 months ago

That's a good question here, my short answer is that the default action should carefully select by its senario. For example, create new folder, the default button should be confirm, but for delete action, the default action should be cancel.

added PR: https://github.com/solosky/pixl.js/pull/211

PonyOny commented 8 months ago

Just want to let you know, I have updated to new version with the confirm dialog and I have the same problem, as arrows move right/left to select cancel or accept and then you have to press to confirm it then jumps to the other button and confirms, I understood that the confirm dialog would directly work without having to press central confirm button, if cancel is on the right side just pressing right button would confirm the action, just wanted to let you know as my device reset 3 times until i could exit to base menu having to set all my settings 3 times.

That's exactly order what I have done here. No CENTER button is required here.

mui_msg_box_set_btn_text(app->p_msg_box, _T(CONFIRM), NULL, _T(CANCEL)); mui_msg_box_set_btn_focus(app->p_msg_box, 2);

solosky commented 8 months ago

Hi @PonyOny , I don't have such issue and no one else report this issue too, so I consider your wheel switch may be broken, you may need to replace one or to request your seller to replace a new one.