[Card emulator] feature: filename to slots nickname - Githubissues

solosky / pixl.js

An emulator for Amiibo!

GNU General Public License v2.0

557 stars 109 forks source link

[Card emulator] feature: filename to slots nickname #208

Closed MirakelDev closed 6 months ago

netlify[bot] commented 6 months ago

Deploy Preview for aquamarine-heliotrope-f610d4 ready!

Name	Link
Latest commit	8ced83668e35d23627e1b211743b5cde1ef036eb
Latest deploy log	https://app.netlify.com/sites/aquamarine-heliotrope-f610d4/deploys/65ae1815bde90b000870bc8b
Deploy Preview	https://deploy-preview-208--aquamarine-heliotrope-f610d4.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MirakelDev commented 6 months ago

accidentally force-pushed to that branch but already resetted it back to https://github.com/MirakelDev/pixl.js/commit/0174eebbdcd5f846c2dd6862ba507793985b56ab. just ignore last message about force push

MirakelDev commented 6 months ago

~~please check https://github.com/solosky/pixl.js/pull/208/commits/64046a6345e70825b3242a2fad958ac8aebd0de3~~

EDIT: replace glyph with "...", please check https://github.com/solosky/pixl.js/pull/208/commits/2207be5c6944d1f4d1e732c04fb8f0c338fffc78 ellipsis_glyph

solosky commented 6 months ago

Hi, thanks for patient update on this PR< I am good for the current code, can I accept the PR and merge develop branch?

MirakelDev commented 6 months ago

LGTM

You are welcome to merge 🎉

solosky commented 6 months ago

Thanks for your contribution 🎉🎉🎉