solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

Russian translation #220

Closed hummer007 closed 3 months ago

solosky commented 4 months ago

Hi sir, thank your contribution.

I have tested the PR, but failed, here are issues:

impeeza commented 4 months ago

I was able to build a release using your commits as base and adding some files, but the result have a rare behavior:

image

image

The emulator and dabatabase have no title: image image

image

image

the space between characters is odd.

This are the files I did use, I don't know if @solosky can help on this. may be the used font have the

ru.zip

impeeza commented 4 months ago

the build is on

https://github.com/impeeza/pixl.js/actions/runs/8405297258

MayanKoyote commented 4 months ago

Very good! But a few notes:

  1. Russian ellipsis consists of three dots. Three. No more and no less.
  2. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L31 -> "Возврат к настройкам по умолчанию" or "Восстановить настройки по умолчанию" or ""Сброс настроек к значениям по умолчанию"" or simply "Сброс настроек" to fit the width of the our miniature screen.
  3. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L42 but what if female will use the device? -> "Понятно"
  4. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L44 От слова 'автослучка' что ли? Без комментариев. Тут Нужно придумать что то другое.
  5. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L81 -> "[НАЗАД]"
  6. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L100 -> "Обозреватель" на худой конец "Браузер" as option
  7. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L102 -> or "Моё избранное..." or simply "Избранное..." coz of: https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L129 -> or "Моя коллекция..." does not require unsaid semantic completion to gain meaning
  8. https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L116 -> "[Подробнее...]" maybe? Yes, our miniature screen.
  9. Word 'Factory' in lines: https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L152 https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L153 https://github.com/solosky/pixl.js/blob/7ad3837df360ef0c6f336cae2044f0def869da9b/fw/application/src/i18n/ru_RU.c#L168 I suspect that nothing related to the 'factory' as 'factory' was meant there. A quick machine translation from Chinese (the original language here is Chinese) gives this: Reset.. Card initialization successful Card type has been modified\nReset card data?
MayanKoyote commented 4 months ago
  • Extra flash memory may used to store glyph of Russian charaters, we need reserve enough flash memory for further code enhancement.

~~This will depend on how good the translation will look (fit into the width of the screen). Russian words are relatively long/wide. But to understand this we need to see it on real screen first, and for this we need a suitable font.~~ Perhaps something like 'u8g2_font_cu12_t_cyrillic' or 'crox' or 'GNU Unifont' (or anything even better). The font is basically ready, all that remains is to fit the texts into the width of the screen.

This problem is no longer a problem. Everything was resolved, done and finished.

Wohlstand commented 3 months ago

First in my mind why Russian glyphs drawn as this: they taken from the Chinese GBK charset, and to properly render Cyrillic it's need to have dedicated Cyrillic font that will have proper glyphs proportions

solosky commented 3 months ago

Close this PR because we have Russian support contributed by @MayanKoyote via #243