solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

Add Russian language support #221

Closed hummer007 closed 4 months ago

hummer007 commented 4 months ago

Russian language has been added to the language options in the internationalization files. New entries for Russian (ru) have been made in each of the existing language files and a new language file has been created specifically for Russian (ru_RU.js). The dropdown for language selection in the App has been updated to include this new option.

solosky commented 4 months ago

Thanks!

MayanKoyote commented 4 months ago

Just add a bit of meaning to these lines, otherwise it looks like classic machine translation nonsense. At least something like this:

  1. https://github.com/solosky/pixl.js/blob/5b85e4ccdcd30e2a6244680db0877fbbe9620da7/web/src/i18n/ru_RU.js#L9 -> changeok: 'Переключение языка прошло успешно!',

  2. https://github.com/solosky/pixl.js/blob/5b85e4ccdcd30e2a6244680db0877fbbe9620da7/web/src/i18n/ru_RU.js#L95 -> message: 'Версия встроенного ПО вашего устройства слишком старая. Пожалуйста, обновитесь до последней версии ПО перед использованием функции загрузки.'

hummer007 commented 4 months ago

Just add a bit of meaning to these lines, otherwise it looks like classic machine translation nonsense. At least something like this:

  1. https://github.com/solosky/pixl.js/blob/5b85e4ccdcd30e2a6244680db0877fbbe9620da7/web/src/i18n/ru_RU.js#L9

    -> changeok: 'Переключение языка прошло успешно!',

  2. https://github.com/solosky/pixl.js/blob/5b85e4ccdcd30e2a6244680db0877fbbe9620da7/web/src/i18n/ru_RU.js#L95

    -> message: 'Версия встроенного ПО вашего устройства слишком старая. Пожалуйста, обновитесь до последней версии ПО перед использованием функции загрузки.'

I'm going to modify and make a PR.

hummer007 commented 4 months ago

@MayanKoyote you can check this PR