solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

Update language.h #230

Closed JostenSyon closed 4 months ago

JostenSyon commented 4 months ago

added Italian

netlify[bot] commented 4 months ago

Deploy Preview for aquamarine-heliotrope-f610d4 ready!

Name Link
Latest commit 4e6c0e98860243d4ebd52242f9748c7435ed671e
Latest deploy log https://app.netlify.com/sites/aquamarine-heliotrope-f610d4/deploys/6606c050e95c930008417c93
Deploy Preview https://deploy-preview-230--aquamarine-heliotrope-f610d4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JostenSyon commented 4 months ago

Sorry for that, I did, realising then that wasn’t the proper way, I find the i18n.csv and almost ended of translating it.

Just a question, Spanish translation use the [ ] more than others translation for going back to menu or menu related action, I should strict follow English or I can use like Spanish? Is not so bad but is up to you

Il giorno ven 29 mar 2024 alle 15:03 solosky @.***> ha scritto:

@.**** requested changes on this pull request.

I don't think this PR makes sense. you should commit i18n.csv and releted generated files.

— Reply to this email directly, view it on GitHub https://github.com/solosky/pixl.js/pull/230#pullrequestreview-1968608541, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMTI3JSG3JWAEQ7BW2E4T3Y2VYCLAVCNFSM6AAAAABFONSIF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRYGYYDQNJUGE . You are receiving this because you authored the thread.Message ID: @.***>

solosky commented 4 months ago

Sorry for that, I did, realising then that wasn’t the proper way, I find the i18n.csv and almost ended of translating it. Just a question, Spanish translation use the [ ] more than others translation for going back to menu or menu related action, I should strict follow English or I can use like Spanish? Is not so bad but is up to you Il giorno ven 29 mar 2024 alle 15:03 solosky @.> ha scritto: @*.*** requested changes on this pull request. I don't think this PR makes sense. you should commit i18n.csv and releted generated files. — Reply to this email directly, view it on GitHub <#230 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMTI3JSG3JWAEQ7BW2E4T3Y2VYCLAVCNFSM6AAAAABFONSIF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRYGYYDQNJUGE . You are receiving this because you authored the thread.Message ID: @.>

Yes, in many senarios, I use '[' and ']' to emphasize navigation menu item, such as '[Back]', '[Back to Main Menu]', please keep following this style when you translate to other language.