search

solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

added Italian Language #232

Closed JostenSyon closed 4 months ago

JostenSyon commented 4 months ago

added italian language

netlify[bot] commented 4 months ago

Deploy Preview for aquamarine-heliotrope-f610d4 ready!

Name Link
Latest commit 76b9b4e7eb0adb8d28cefa9b4062d3ad67ce33ab
Latest deploy log https://app.netlify.com/sites/aquamarine-heliotrope-f610d4/deploys/660815495947160008bec5b9
Deploy Preview https://deploy-preview-232--aquamarine-heliotrope-f610d4.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

impeeza commented 4 months ago

Cool, It's great see the community growing, @solosky changing the order of the language definitions on fw/application/src/i18n/language.h, could be problematic? when somebody upgrade the firmware and the new languaje for the index # now is other language, could be confusing for the end user.

solosky commented 4 months ago

Cool, It's great see the community growing, @solosky changing the order of the language definitions on fw/application/src/i18n/language.h, could be problematic? when somebody upgrade the firmware and the new languaje for the index # now is other language, could be confusing for the end user.

Good point. New language should be added in end of the language enum list, because the language setting persisted as enum index to choose display language, if new language inserted in middle of the language enum, it will change the index means of actual language loaded in the initialize stage for language display.

solosky commented 4 months ago

Looks good, thanks for your contribution.