search

solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

The 'amibo' application automatically adds two-dot ellipsis to (some) text lines. #236

Closed MayanKoyote closed 3 months ago

MayanKoyote commented 3 months ago

For most menu item text lines, the ellipsis is specified in the localization file. For example, like here: https://github.com/solosky/pixl.js/blob/223609b07aa2b97a6adfeb8b2932985d1c4d3e64/fw/application/src/i18n/pt_PT.c#L71 But in two cases (same app, 'amiibo'), the application itself adds a two-dot ellipsis instead: https://github.com/solosky/pixl.js/blob/223609b07aa2b97a6adfeb8b2932985d1c4d3e64/fw/application/src/app/amiibo/scene/amiibo_scene_file_browser_menu.c#L301 https://github.com/solosky/pixl.js/blob/223609b07aa2b97a6adfeb8b2932985d1c4d3e64/fw/application/src/app/amiibo/scene/amiibo_scene_file_browser_menu.c#L303

Is it possible to put this in a uniform order (i.e. the ellipsis is specified in the localization file)?

Schokobecher commented 3 months ago

I would vote for putting the ellipsis inside the i18n.csv to unify all text as much as possible. In addition to that, ellipsis are typically three, not two dots. I already started working on reworking the de_DE translation, so I could integrate this across the board.

solosky commented 3 months ago

I would vote for putting the ellipsis inside the i18n.csv to unify all text as much as possible. In addition to that, ellipsis are typically three, not two dots. I already started working on reworking the de_DE translation, so I could integrate this across the board.

aggreed.

Schokobecher commented 3 months ago

_L_DELETE is also used in the context of https://github.com/solosky/pixl.js/blob/223609b07aa2b97a6adfeb8b2932985d1c4d3e64/fw/application/src/app/amiibo/scene/amiibo_scene_file_browser_menu.c#L258

Which would to look like this after swapping over the ellipsis to i18n.csv

Delete... FILENAME ?

Is that acceptable? Or do we need another string in i18n.csv, such as _L_DELETE_FILE (since there is already a _L_DELETE_TAG, too)

We also should be able to move the various punctuations with something like this:

_L_DELETE_FILE,Delete %s ?
        snprintf(msg, sizeof(msg), _T(DELETE_FILE), string_get_cstr(app->current_file));

Delete FILENAME ?

MayanKoyote commented 3 months ago

Be that as it may, but something needs to be done about it.