solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

Move punctuation to i18n.csv #240

Closed Schokobecher closed 3 months ago

Schokobecher commented 3 months ago

This should close #236

Changes:

I compiled and flashed this version, and English/German look correct. Let me know if anything needs to be reworked, or I missed anything!

MayanKoyote commented 3 months ago

IMG_3491

What if to use: for header text - line [_L_APP_AMIIDB_TIPS], its content is: 'Confirm' in English, 'Hint' in Simplified Chinese, 'Attention' in Russian. for confirmation button text - line [_L_CONFIRM], its content is: 'Confirm' in English, 'Sure' in Simplified Chinese, 'Yes' in Russian. ?

impeeza commented 3 months ago

Hello there, @solosky Should we then use on the CSV file the ellipsis character instead of the three dots?

for roman alphabet there is the Unicode Character «…» (U+2026); and as far I know, (for this please correct me) for Chinese, Unicode provides an explicitly centered U+22EF «⋯» MIDLINE HORIZONTAL ELLIPSIS character

that's OK or better to use the traditional dots?

Schokobecher commented 3 months ago

I agree with @MayanKoyote three "Delete" on one screen is a bit much, at least the button should be _L_CONFIRM

@impeeza I would prefer the Unicode version as its spacing is smaller compared to just regular dots. Both are included in wenquanyi_9pt_u8g2.bdf so it should be a drop-in replacement.

impeeza commented 3 months ago

Hello there, @Schokobecher which one is the unicode version? I will like to try it on my branch before post a update

Schokobecher commented 3 months ago

@impeeza It's the one you posted, U+2026 and U+22EF are both provided by the font

impeeza commented 3 months ago

I was making some test and seems the FONT uses the same drawing for the ellipsis both are draw as tree dots on the middle of the vertical space look the custom created firmware:

image

image

image

my test file is on the branch ellipsis of my fork:

https://github.com/impeeza/pixl.js/blob/impeeza-Ellipsis/fw/data/i18n.csv

as you can see on the Chinese languages I use U+22EF and for the rest of languages U+2026 but on the device both are similar.

U+22EF is like three dots image

U+2026 is like three small dashes. image

impeeza commented 3 months ago

By the way I am very pro to use the Unicode character for ellipsis instead of three separated dots

MayanKoyote commented 3 months ago

It's already have been discussed: https://github.com/solosky/pixl.js/pull/208 So either look for other already-made ellipses in the font, or look for an empty space (if there is one) intended for one of the possible ellipsis variants (so as not to spoil the font with gags) and draw the symbol yourself.

btw, check this one: U+2026 (Horizontal Ellipsis) redrawn as it should be (I hope so), U+22EF (Midline Horizontal Ellipsis) left as is. wenquanyi_9pt_u8g2-u2026.zip

IMG_3540