solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

Add message box when clicking "More" in AmiiDB results list #245

Closed Schokobecher closed 3 months ago

Schokobecher commented 3 months ago

This should close #241

Pressing [More...] leads the user to this screen: 673E5496-B3E3-410C-8FE0-7A301D90D5F2

Confirming leads them back to the search result scene.

To-do: Translate _L_APP_AMIIDB_MORE_MESSAGE in other languages

MayanKoyote commented 3 months ago

Since this is both information and advice/instructions for action, why not use the [_L_KNOW] button here (which means “Got it”)? Because there is essentially nothing to confirm in such a situation.

Schokobecher commented 3 months ago

Both strings convey the same meaning. You could argue that we can remove both, and just use OK in any instance where they are currently in use, and nobody would notice or care.

The user confirms (Confirm)/acknowledges(Got it) that he has seen

MayanKoyote commented 3 months ago

In situations where the user can say 'I confirm', he can also say 'I do not confirm' in case he doesn't like it. In other words it's 'I cancel' or simply 'Cancel'. In the case where the user does not have the power of choice (as in this search case), the user can only take note of it by saying 'Got it'. Just like in case of missing key-file.

Schokobecher commented 3 months ago

In which case the User can always say Ok and Cancel, just like in most programs. So the right thing would be to ditch both strings entirely and use only Ok across the board.

image

image

solosky commented 3 months ago

I vote for "OK"

Schokobecher commented 3 months ago

I changed it to _L_KNOW for know, since changing unrelated files doesn't really fit this PR's purpose.

139F939D-2362-42F2-814C-7F1BAFC49F38_1_102_o

solosky commented 3 months ago

Thanks