solosky / pixl.js

An emulator for Amiibo!
GNU General Public License v2.0
557 stars 109 forks source link

Rework the text of the deletion confirmation window for the "Amiibo Emulator" app #249

Closed MayanKoyote closed 2 months ago

MayanKoyote commented 3 months ago

Since recently we have a new delete confirmation window in the 'Amiibo Emulator' app file browser. (It is new because of the redesign of the display of the ellipsis of some items in the file browser. https://github.com/solosky/pixl.js/pull/240 ) This window looks like this now: 01 As already noted there are too many 'Delete' words here.

So I looked at the situation in the neighboring app, 'Amiibo Database', and there is a bit similar operation there: 02 The window title there is taken from [_L_APP_AMIIDB_TIPS], the consent button is from [_L_APP_AMIIDB_CONFIRM], the disagree button is, well, the same, 'CANCEL'.

With it in mind, I created a new variable for translation called [_L_TIPS] that has the same meaning as [_L_APP_AMIIDB_TIPS], but does not have only one app affiliation in the name. And the window began to look like this: 03

Pros:

Cons:

Well, something like this.

Schokobecher commented 3 months ago

Borrowing from https://github.com/solosky/pixl.js/pull/245#issuecomment-2045491039

Maybe OK and Cancel would be appropriate here too?

MayanKoyote commented 3 months ago

The main thing I propose here - is the uniformity of such windows among all firmware apps. And the label on the button itself can be edited in the localization file. In my localization, for example, both [_L_CONFIRM] & [_L_APP_AMIIDB_CONFIRM] button shows a simple “Yes” instead of the pretentious “Confirm”.

solosky commented 3 months ago

Sorry reply late, but I think it's better to the the text of left button should be "Delete". Confirm cannot hightlight the action behivior the button will do.

MayanKoyote commented 3 months ago

So we need additional 'Delete' then, but this time without ellipsis. And this will not lead to the unification of such windows between apps.

Schokobecher commented 2 months ago

but I think it's better to the the text of left button should be "Delete". Confirm cannot hightlight the action behivior the button will do.

Windows traditionally uses Yes/No, most Programs also either stick to that, have Ok/Cancel, or very wild approaches (Confirm/Accept/Delete/)

image

macOS and most Linux DE tend to use Delete/Cancel

impeeza commented 2 months ago

may be where be used, because some common dialog is OK - Cancel:

Tljma

impeeza commented 2 months ago

also there is the eternal question: Cancel - OK or OK - Cancel

https://www.nngroup.com/articles/ok-cancel-or-cancel-ok/

Schokobecher commented 2 months ago

To me, Ok — Cancel or Cancel — Ok doesn't matter, as long as the confirmation button is not selected by default. Too many times have I pressed space bar or another key just to accept things I didn't get to look at. :(

MayanKoyote commented 2 months ago

Let's not talk about Windows. They can't even handle creating a consistent user interface.