solresol / wordplanes

Are many of our word vectors actually expressible as planes in 2D space?
1 stars 0 forks source link

Sweep: plane class #2

Closed solresol closed 10 months ago

solresol commented 10 months ago

Details

Write a class called Plane. The constructor should take 3 points in a high dimensional vector space, and calculate the plane that passes through them. It should have a method that when given a point in that high dimensional vector space returns the distance from that point to the hyperplane (and what point on the hyperplane it was closest to)

Checklist - [X] Create `plane.py` ✓ https://github.com/solresol/wordplanes/commit/78fd01ccba8063fac8815c7e2131db43e5e75ff0 [Edit](https://github.com/solresol/wordplanes/edit/sweep/plane_class/plane.py)
sweep-ai[bot] commented 10 months ago

🚀 Here's the PR! #3

See Sweep's progress at the progress dashboard!
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: f7a8c7b284)

[!TIP] I can email you next time I complete a pull request if you set up your email here!


Actions (click)

GitHub Actions failed

The sandbox appears to be unavailable or down.


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/solresol/wordplanes/blob/d3f25b980c6474d93ec182457a0b668f577575ef/README.md#L1-L1

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/plane_class.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord