Closed solresol closed 9 months ago
None
)[!TIP] I can email you next time I complete a pull request if you set up your email here!
Here are the GitHub Actions logs prior to making any changes:
0a0f512
Checking .github/workflows/build.yml for syntax errors... ✅ .github/workflows/build.yml has no syntax errors!
1/1 ✓Checking .github/workflows/build.yml for syntax errors... ✅ .github/workflows/build.yml has no syntax errors!
Sandbox passed on the latest main
, so sandbox checks will be enabled for this issue.
I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.
.github/workflows/build.yml
✓ https://github.com/solresol/wordplanes/commit/32bdf1fafa986080c5a485abaa66f144b8eae694 Edit
Modify .github/workflows/build.yml with contents:
• Change the command that generates the SQLite database to output the file as `~/glove/glove.50d.sqlite` instead of `~/glove/glove.db`. This can be done by modifying the command in the "Convert embeddings to SQLite database" step.
• The modified command should look like this: `python embeddings2sqlite.py ~/glove/glove.6B.50d.txt ~/glove/glove.50d.sqlite`
--- +++ @@ -32,4 +32,4 @@ unzip -o -d ~/glove ~/glove/glove.6B.zip fi - name: Convert embeddings to SQLite database - run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.db --table glove --dimensionality 50 --commit-after 1000 + run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.50d.sqlite --table glove --dimensionality 50 --commit-after 1000
.github/workflows/build.yml
✓ Edit
Check .github/workflows/build.yml with contents:
Ran GitHub Actions for 32bdf1fafa986080c5a485abaa66f144b8eae694:
• build: ✓
.github/workflows/build.yml
✓ https://github.com/solresol/wordplanes/commit/d06984e3215b3a6bb20ac2fc5d29614481405494 Edit
Modify .github/workflows/build.yml with contents:
• Add a new step at the end of the workflow to upload the SQLite database as an artifact. This can be done using the `actions/upload-artifact@v2` Github action.
• The new step should look like this: ```
--- +++ @@ -32,4 +32,9 @@ unzip -o -d ~/glove ~/glove/glove.6B.zip fi - name: Convert embeddings to SQLite database - run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.db --table glove --dimensionality 50 --commit-after 1000 + run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.50d.sqlite --table glove --dimensionality 50 --commit-after 1000 + - name: Upload SQLite database + uses: actions/upload-artifact@v2 + with: + name: glove.50d.sqlite + path: ~/glove/glove.50d.sqlite
.github/workflows/build.yml
✓ Edit
Check .github/workflows/build.yml with contents:
Ran GitHub Actions for d06984e3215b3a6bb20ac2fc5d29614481405494:
• build: ✓
I have finished reviewing the code for completeness. I did not find errors for sweep/make_the_sqlite_database_an_artifact
.
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord
Details
In
.github/workflows/build.yml
the final step creates a file~/glove/glove.db
Update it to be called
~/glove/glove.50d.sqlite
and then make that an artifact of the build process.Checklist
- [X] Modify `.github/workflows/build.yml` ✓ https://github.com/solresol/wordplanes/commit/32bdf1fafa986080c5a485abaa66f144b8eae694 [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L33-L36) - [X] Running GitHub Actions for `.github/workflows/build.yml` ✓ [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L33-L36) - [X] Modify `.github/workflows/build.yml` ✓ https://github.com/solresol/wordplanes/commit/d06984e3215b3a6bb20ac2fc5d29614481405494 [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L37-L37) - [X] Running GitHub Actions for `.github/workflows/build.yml` ✓ [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L37-L37)