solresol / wordplanes

Are many of our word vectors actually expressible as planes in 2D space?
1 stars 0 forks source link

Sweep: make the sqlite database an artifact #62

Closed solresol closed 9 months ago

solresol commented 9 months ago

Details

In .github/workflows/build.yml the final step creates a file ~/glove/glove.db

Update it to be called ~/glove/glove.50d.sqlite and then make that an artifact of the build process.

Checklist - [X] Modify `.github/workflows/build.yml` ✓ https://github.com/solresol/wordplanes/commit/32bdf1fafa986080c5a485abaa66f144b8eae694 [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L33-L36) - [X] Running GitHub Actions for `.github/workflows/build.yml` ✓ [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L33-L36) - [X] Modify `.github/workflows/build.yml` ✓ https://github.com/solresol/wordplanes/commit/d06984e3215b3a6bb20ac2fc5d29614481405494 [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L37-L37) - [X] Running GitHub Actions for `.github/workflows/build.yml` ✓ [Edit](https://github.com/solresol/wordplanes/edit/sweep/make_the_sqlite_database_an_artifact/.github/workflows/build.yml#L37-L37)
ifost-autodev[bot] commented 9 months ago

🚀 Here's the PR! #63

See Sweep's progress at the progress dashboard!
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: None)

[!TIP] I can email you next time I complete a pull request if you set up your email here!


Actions (click)

GitHub Actions✓

Here are the GitHub Actions logs prior to making any changes:

Sandbox logs for 0a0f512
Checking .github/workflows/build.yml for syntax errors... ✅ .github/workflows/build.yml has no syntax errors! 1/1 ✓
Checking .github/workflows/build.yml for syntax errors...
✅ .github/workflows/build.yml has no syntax errors!

Sandbox passed on the latest main, so sandbox checks will be enabled for this issue.


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/solresol/wordplanes/blob/0a0f512caa39596ac8cf8b7a8c545ba5787b5fd5/.github/workflows/build.yml#L1-L34

Step 2: ⌨️ Coding

--- 
+++ 
@@ -32,4 +32,4 @@
           unzip -o -d ~/glove ~/glove/glove.6B.zip
         fi
     - name: Convert embeddings to SQLite database
-      run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.db --table glove --dimensionality 50 --commit-after 1000
+      run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.50d.sqlite --table glove --dimensionality 50 --commit-after 1000

Ran GitHub Actions for 32bdf1fafa986080c5a485abaa66f144b8eae694:
• build:

--- 
+++ 
@@ -32,4 +32,9 @@
           unzip -o -d ~/glove ~/glove/glove.6B.zip
         fi
     - name: Convert embeddings to SQLite database
-      run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.db --table glove --dimensionality 50 --commit-after 1000
+      run: python embeddings2sqlite.py --embeddings-file ~/glove/glove.6B.50d.txt --sqlite-database ~/glove/glove.50d.sqlite --table glove --dimensionality 50 --commit-after 1000
+    - name: Upload SQLite database
+      uses: actions/upload-artifact@v2
+      with:
+        name: glove.50d.sqlite
+        path: ~/glove/glove.50d.sqlite

Ran GitHub Actions for d06984e3215b3a6bb20ac2fc5d29614481405494:
• build:


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/make_the_sqlite_database_an_artifact.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord