search

solspace / craft-freeform

Freeform for Craft: The most reliable form builder that's ready for wherever your project takes you.
https://docs.solspace.com/craft/freeform/v5/
Other
47 stars 59 forks source link

PurgeUnfinalizedAssetsJob runs constantly #1590

Open jaspertandy opened 5 days ago

jaspertandy commented 5 days ago

What happened?

My queue is constantly filling up with PurgeUnfinalizedAssetsJob because it seems to get run during init:

https://github.com/solspace/craft-freeform/blob/a0da095a587af762d7e6aecfd685b8d1c512a3ed/packages/plugin/src/Freeform.php#L621

So when I'm looking at the queue, every time the queue polls, it hits init and adds another PurgeUnfinalizedAssetsJob. Is this intended behaviour? The same is also true of every CP asset that gets loaded, every other async request to an admin URL. There must be a way to disable this? If Freeform needs housekeeping to be done, I think it should be done on a cron but I don't think there's any way to configure it like that. The options in the download are all times, so I don't think I can set false or something.

Errors and Stack Trace (if available)

No response

How can we reproduce this?

Freeform Edition

Pro

Freeform Version

5.6.6

Craft Version

4.12.7

When did this issue start?

After upgrading from older Freeform version

Previous Freeform Version

unknown when this started happening

gustavs-gutmanis commented 5 days ago

Thanks for reporting this @jaspertandy,

Your concerns are very valid, we will improve this functionality.

jaspertandy commented 5 days ago

@gustavs-gutmanis thanks very much!