search

soluble-ai / kubetap

Kubectl plugin to interactively proxy Kubernetes Services with ease
https://soluble-ai.github.io/kubetap/
Apache License 2.0
524 stars 44 forks source link

Trim fix #8

Closed alexivkin closed 3 years ago

alexivkin commented 3 years ago

Fix the overzealous trim which also removed matching characters from the domain names: "https://test-cluster" became "est-cluster"

(also thanks for the great tool !)

Signed-off-by: Alex Ivkin alexivkin@users.noreply.github.com

alexivkin commented 3 years ago

something seems wrong with the gh actions build - the fix itself is trivial and should not cause it

Eriner commented 3 years ago

Yes, the build has been broken because of pip something or other. Have been hoping it would fix itself. I'll go fix that and re-run these tests! Thanks for the fix @alexivkin!

Eriner commented 3 years ago

Merged! Thanks for the fix @alexivkin!