solus-cold-storage / journal

GNU General Public License v2.0
9 stars 5 forks source link

Custom colour schemes #17

Closed cybre closed 9 years ago

cybre commented 9 years ago

An option to change the colour scheme would be great. The app could ship with a few colour schemes by default (Monokai, Solarized (Light and Dark)).

ryanleesipes commented 9 years ago

I've been wanting to do this for a while. Going to mark this as an enhancement.

On Sun, Feb 15, 2015, 10:45 AM Stefan Ric notifications@github.com wrote:

An option to change the colour scheme would be great. The app could ship with a few colour schemes by default (Monokai, Solarized (Light and Dark)).

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/17.

ryanleesipes commented 9 years ago

All but Monokai are in there, I will create another issue for adding that scheme.

zesterer commented 9 years ago

Dunno. It should auto-detect all installed themes. If its not showing up, it's because it's not installed. On 18 Feb 2015 22:56, "Ryan Sipes" notifications@github.com wrote:

All but Monokai are in there, I will create another issue for adding that scheme.

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/17#issuecomment-74966637.

ryanleesipes commented 9 years ago

Unfortunately @zesterer this isn't the case anymore. It will detect the themes, but they will not work due to the current implementation (if they are not hard-coded - change was made to accommodate glib). However, I think we need to look at how to tackle that issue before moving forward. I have some ideas, we should talk about them.

ryanleesipes commented 9 years ago

@cybre check out #33 it has been reopened in order to address this is a really awesome way.