solus-cold-storage / journal

GNU General Public License v2.0
9 stars 5 forks source link

[FEATURE] Ctrl + Q to Quit #46

Closed Justinzobel closed 9 years ago

Justinzobel commented 9 years ago

As per the subject :D

ryanleesipes commented 9 years ago

Is this a shortcut in other editors?

On Sun, Mar 1, 2015, 11:05 PM Justin notifications@github.com wrote:

As per the subject :D

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/46.

zesterer commented 9 years ago

As far as I'm aware, it is. If not, then it's a good one.

Although be careful. If Ctrl+W is close tab, then a tiny slip of they fingers can spell disaster :D

ikeydoherty commented 9 years ago

ALT+F4? :)

zesterer commented 9 years ago

Touché

ryanleesipes commented 9 years ago

Actually what I was thinking (alt+F4). However, I may implement something for closing current tab and cycling through tabs.

Justinzobel commented 9 years ago

Barry why did you just close this? Is it implemented?

Ryan it is a shortcut in Gedit and another though I can't remember what it was.

Alt F4 is a bit A) more difficult and B) a Windows thing :P

On Tue, 3 Mar 2015 at 05:58 Ryan Sipes notifications@github.com wrote:

Actually what I was thinking (alt+F4). However, I may implement something for closing current tab and cycling through tabs.

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/46#issuecomment-76791088.

Justinzobel commented 9 years ago

Also being next to close tab isn't an issue, you can always re-open Journal, and if the save-mechanism is working fine (ie not allowing a user to close a tab that isn't saved without a prompt) I see no issues at all....

On Tue, 3 Mar 2015 at 07:41 Justin Zobel justin.zobel@gmail.com wrote:

Barry why did you just close this? Is it implemented?

Ryan it is a shortcut in Gedit and another though I can't remember what it was.

Alt F4 is a bit A) more difficult and B) a Windows thing :P

On Tue, 3 Mar 2015 at 05:58 Ryan Sipes notifications@github.com wrote:

Actually what I was thinking (alt+F4). However, I may implement something for closing current tab and cycling through tabs.

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/46#issuecomment-76791088.

ryanleesipes commented 9 years ago

Confirmed as a keyboard shortcut in Gedit. I will implement it.

On Mon, Mar 2, 2015, 3:12 PM Justin notifications@github.com wrote:

Also being next to close tab isn't an issue, you can always re-open Journal, and if the save-mechanism is working fine (ie not allowing a user to close a tab that isn't saved without a prompt) I see no issues at all....

On Tue, 3 Mar 2015 at 07:41 Justin Zobel justin.zobel@gmail.com wrote:

Barry why did you just close this? Is it implemented?

Ryan it is a shortcut in Gedit and another though I can't remember what it was.

Alt F4 is a bit A) more difficult and B) a Windows thing :P

On Tue, 3 Mar 2015 at 05:58 Ryan Sipes notifications@github.com wrote:

Actually what I was thinking (alt+F4). However, I may implement something for closing current tab and cycling through tabs.

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/46#issuecomment-76791088.

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/46#issuecomment-76824242.

zesterer commented 9 years ago

To answer your question Justin, I was typing fast and pressed Tab to switch the the next element on the page, assuming it would be "comment". Turns out it was "close and comment"...

Justinzobel commented 9 years ago

Heh github to the rescue! Bit of a crap tab order.

On Tue, 3 Mar 2015 at 09:12 Barry Smith notifications@github.com wrote:

To answer your question Justin, I was typing fast and pressed Tab to switch the the next element on the page, assuming it's be "comment". Turns out it was "close and comment"...

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/46#issuecomment-76843150.

ryanleesipes commented 9 years ago

This was taken care of by @michaelrutherford