search

solus-cold-storage / journal

GNU General Public License v2.0
9 stars 5 forks source link

Problems with tabs when dragging out of the window. #50

Closed cybre closed 9 years ago

cybre commented 9 years ago

So, let's do this in steps:

  1. Open a second tab (with "Always show tabs" disabled)
  2. Drag one of the tabs out of the window. You can see that in both of the windows, the single tab is visible. Same thing happens when attaching tabs, too.
ryanleesipes commented 9 years ago

Yes, I knew about this one. Was thinking about if I wanted to expose the one tab in the event that the user wanted to move it back.

ryanleesipes commented 9 years ago

@cybre I assume you would prefer it not be exposed?

cybre commented 9 years ago

I'm not sure. It does look weird but usability-wise, leaving it visible makes sense.

On Wed, 18 Mar 2015 15:38 Ryan Sipes notifications@github.com wrote:

@cybre https://github.com/cybre I assume you would prefer it not be exposed?

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/50#issuecomment-83000186.

cybre commented 9 years ago

One thing I would change is: when dragging out the last tab ("Always show tabs" enabled), close the window. Currently, dragging out the last tab leaves a notebook-less window open.

On Wed, 18 Mar 2015 19:34 Stefan Ric stfric369@gmail.com wrote:

I'm not sure. It does look weird but usability-wise, leaving it visible makes sense.

On Wed, 18 Mar 2015 15:38 Ryan Sipes notifications@github.com wrote:

@cybre https://github.com/cybre I assume you would prefer it not be exposed?

— Reply to this email directly or view it on GitHub https://github.com/evolve-os/journal/issues/50#issuecomment-83000186.

ryanleesipes commented 9 years ago

That is a good idea @cybre - I will see if I can do that.

ryanleesipes commented 9 years ago

Marking this closed as I think current behavior is pretty good.