search

solus-project / budgie-desktop

I Tawt I Taw A Purdy Desktop
https://solus-project.com/
2.33k stars 158 forks source link

Dark theme cannot be switched on or off in version 10.5.1 #1881

Closed ArjenR closed 4 years ago

ArjenR commented 4 years ago

Description

To work more easily with librecad I am used to switching off the dark theme in budgie-desktop. After the recent update to 10.5.1 the toggle does not work. Even not when toggeling /com/solus-project/budgie-panel/dark-theme using the dconf editor.

Budgie version

budgie-desktop 10.5.1

Operating system

Solus 4 updated to 5-10-2019

Steps to reproduce the issue

Start "Budgie Desktop Settings" Go to Style tab Switch dark theme Off

Actual result

Theme stays dark

Expected result

Theme switches to the light version.

Additional information

Using the dconf editor to toggle /com/solus-project/budgie-panel/dark-theme also has no effect.

JoshStrobl commented 4 years ago

And what is your GTK Theme?

JoshStrobl commented 4 years ago

I just tested it with Plata (not Plata-Noir) and toggling on and off the dark theme, it works as expected. Having it as Plata-Noir specifically didn't cause it to toggle, which is expected behavior (I want to add better handling around this but that's more a feature than a bug), and it isn't going to obviously apply to all applications if you're using Plata + Dark Theme as opposed to Plata-Noir because Qt5 applications aren't going to check for a gsettings dark-theme schema value but rather what the current GTK theme is to inherit styles from that (if Qt5 styles support is installed, which it is in Solus).

ArjenR commented 4 years ago

Ok thanks for testing and your reply. It happens to be a quite fresh install. No changes in visuals other then the background. I am not at that machine right now. But iirc it said Plata-Noir.

Will try with your suggestion later. On Oct 5, 2019, 15:47 +0200, Joshua Strobl notifications@github.com, wrote:

I just tested it with Plata (not Plata-Noir) and toggling on and off the dark theme, it works as expected. Having it as Plata-Noir specifically didn't cause it to toggle, which is expected behavior (I want to add better handling around this but that's more a feature than a bug). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

JoshStrobl commented 4 years ago

Yea in the future I'd like to have a system in place that'll swap between the themes when you toggle on / off dark mode so it'll be consistent and enforced properly across the board, but right now my work on desktop icons is taking priority :)

ArjenR commented 4 years ago

Ok so indeed, switching to Plata or Plata-luminous even, enabled the toggle to have effect. I see there is logic to it. Success on the desktop icons.

JoshStrobl commented 4 years ago

I'm going to mark this as resolved / invalid then, with the note that while I do agree this may not fully be the expected behavior by the user, it is in fact currently the intended behavior. The behavior of it is something I will improve within the Budgie 10.5 series however.