solus-project / budgie-desktop

I Tawt I Taw A Purdy Desktop
https://solus-project.com/
2.33k stars 158 forks source link

No Pin to Panel option for Ambient Noise #750

Closed aldoiljazi closed 5 years ago

aldoiljazi commented 7 years ago

There is no Pin to Panel Ambient Noise option.

Screenshot:

ambient noise bug

Vistaus commented 7 years ago

Yeah, I've also noticed there are quite a few apps where the option's missing.

ckrzen commented 7 years ago

I find that if I add the *.desktop file to:

~/.local/share/applications/

AND(in some cases):

right-click on the *.desktop entry | select the the permissions tab | and check the "Allow executing file as program" tick-box

that that then exposes the "Pin to panel" option on the Budgie menu.

HTH!

On Sun, Dec 4, 2016 at 3:56 AM, Heimen Stoffels notifications@github.com wrote:

Yeah, I've also noticed there are quite a few apps where the option's missing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/budgie-desktop/budgie-desktop/issues/750#issuecomment-264694421, or mute the thread https://github.com/notifications/unsubscribe-auth/AGnuRUczQYSoBRXvGkRnOTdLtxJilPWYks5rEo5YgaJpZM4LDbCd .

ghost commented 7 years ago

Yeah, I've also noticed there are quite a few apps where the option's missing.

Telling us which apps could be more useful 😉

Vistaus commented 7 years ago

You're right, I'm sorry.

From the top of my head (which I encountered): -Dolphin (the KDE File Manager) -Vivaldi (web browser) -Vivaldi apps (using Vivaldi's --app argument in a launcher) -Xfe (file manager) -Xfw (text editor part of the Xfe suite)

I'll add more to the list when I remember or encounter more.

Btw, a workaround is to use dconf-editor and add those apps to the icon-tasklist key. That way those apps do get added. The downside though is that when you click on one of those icons it opens up a second icon with the running instance...

Vistaus commented 7 years ago

Another one to add to the previous list: Gramps.

ikeydoherty commented 7 years ago

If they don't provide a WM_CLASS there's literally nothing I can do. Ambient is one of them situations. Budgie can only act on the information provided by the app. If they omit the information, or they break it - I have nothing to associate to a .desktop file

ikeydoherty commented 7 years ago

TL;DR It's not a magician. It makes informed decisions.

ikeydoherty commented 7 years ago

This change will help a bit though:

https://github.com/budgie-desktop/budgie-desktop/commit/da75a4e484b67a1f9dbe1688a81c7e7661ac4a98

JoshStrobl commented 7 years ago

Someone please confirm as to whether or not the latest Budgie resolves this issue.

aldoiljazi commented 7 years ago

Now when I launch Ambient Noise, I don't see any window launching. I do listen to the "noise" though.

Probably a separate bug?

baimafeima commented 7 years ago

Yeah, I don't see any window launching either. The only way to shut it down is via the terminal.

Vistaus commented 7 years ago

Another one to add to the list: QupZilla.

Radagast commented 7 years ago

With the Panel or Panel Dock (Icon Task List I guess), I cannot pin Firefox Nightly.

ikeydoherty commented 7 years ago

OK as I've said before the .desktop file needs to actually match up to the wmclass - make sure firefox nightly actually does this

joebonrichie commented 6 years ago

This is not a budgie bug, I fixed anoise itself by adding 'StartupWMClass' to it's desktop file. Resolved here: https://dev.solus-project.com/R357:b23a3e6385fc9a8e8083d9363c5ebc41201d9ef8

This can be closed.

joebonrichie commented 6 years ago

Qupzilla fixed https://dev.solus-project.com/R2775:55cd7eb902b012cc7dd508c446a7a8e76680f89c

joebonrichie commented 6 years ago

Vivaldi, dolphin, gramps, all seem to be fine. We don't seem to have xfe in the repos. If anymore applications have this bug please report on phabricator (https://dev.solus-project.com/) instead and I can fix it and also send a patch upstream.

JoshStrobl commented 6 years ago

@joebonrichie Except not all Budgie users use Solus so it'd be better if you file an issue upstream directly with the developers of each app rather than catering specifically to Solus.

joebonrichie commented 6 years ago

Yeah don't worry, i've sent pull requests to QupZilla and ReText so far which have been merged. Still need to do Kdenlive and Anoise.

nessunluogo commented 6 years ago

I had the same problem with PhpStorm. Fixed editing the StartupWMClass to desktop file (in ~/.local/share/applications/). To get the right value, just run in your terminal: xprop WM_CLASS then use the + pointer to click the window. You'll get two strings, use the second as StartupWMClass.

JoshStrobl commented 5 years ago

Confirmed this is resolved with latest IconTasklist + Abomination implementation in git.