search

solus-project / os-installer

Solus Installer
https://solus-project.com/
GNU General Public License v2.0
16 stars 11 forks source link

UEFI - Allow user to select ESP for bootloader installation. #36

Open deepakkapoor23 opened 7 years ago

deepakkapoor23 commented 7 years ago

Installer detects all ESPs but only shows the first suitable one as an option in combobox.

def get_suitable_esp(self): """ Attempt to find the suitable ESP.... """ l = self.dp.collect_esp() if not l: return None e = l[0] if e.freespace < ESP_FREE_REQUIRED: return None return e

ikeydoherty commented 7 years ago

And the issue with that is... ?

deepakkapoor23 commented 7 years ago

Installer is not listing all available ESPs on the system. It only shows the first one it finds with more than 60Mb free space.

List all of them during installation with free space available and let the user decide. Also show a note on screen that at least 60Mb is required.

ikeydoherty commented 7 years ago

You do realise that many systems will happily ignore multiple ESPs - and it's typically only full desktops that are OK with it? Laptops of various vendors (read: shitty firmware) can struggle with multiple ESPs, or just completely ignore them, or provide no mechanism at all to select a secondary.

Sidenote, the method returns the largest ESP with more than 60MB free.