search

solus-project / os-installer

Solus Installer
https://solus-project.com/
GNU General Public License v2.0
16 stars 11 forks source link

Change Gtk.VBox & Gtk.HBox to Gtk.Box #42

Closed tristan957 closed 7 years ago

tristan957 commented 7 years ago

With the upcoming Gtk 4 changes, Gtk.VBox and Gtk.HBox have been deprecated in favor of Gtk.Box with an orientation.

tristan957 commented 7 years ago

FYI I wasn't able to test my changes, but I tried my best to double check stuff for spelling. Let me know if I should do something different stylistically, or fix a bug.

tristan957 commented 7 years ago

Alright @ikeydoherty. Couple weeks later, but I think I got what you wanted me to do. I have explicitly stated orientation=Gtk.Orientation.[ORIENTATION] and spacing=0 in Gtk.Box.__init__() as well as changing all Gtk.Box() to Gtk.Box.new(). The only thing you may have to watch out for is if I put a spacing=0 where it should have been something else. I might've missed something like that.

ikeydoherty commented 7 years ago

Looks legit - thanks bud, if it does crash ill fix it up dont worry, it'd be during startup anyway. Need to get this installer modernised :D

tristan957 commented 7 years ago

No problemo!