solus-project / os-installer

Solus Installer
https://solus-project.com/
GNU General Public License v2.0
16 stars 11 forks source link

XFS support for the installer #56

Closed stobbsm closed 8 months ago

stobbsm commented 6 years ago

Working XFS support, finally

Won't lie, new to python, and this was a learning experience for me. Cleaned up the problems that existed before, and tested in a VM and on a physical (mbr) machine. XFS on root didn't boot for mbr, but that can be solved by adding a /boot partition (at some point).

ikeydoherty commented 6 years ago

What's the panic with GRUB?

stobbsm commented 6 years ago

Grub output: error: attempt to read or write outside of partition. error: not a correct XFS inode.

From what I could research, it seems grub has not been updating it's XFS implementation inline with upstream, so it can't make sense of the filesystem. Not an issue on EFI, as everything is stored on the EFI partition.

Side note: fixed an issue that happened when the home partition isn't assigned. Basically, forgot to give the home_fs variable a value before checking it during partition selection.

unixbhaskar commented 5 years ago

Whoa! that's what stopping me using Solus for sometimes now. Hope @ikeydoherty et al give some consideration to your(Thanks, @stobbsm) work. I shall be trying again if that get merged in the installer.

Without the "bootloader" would even fine.