solus-project / solus-sc

Solus Software Center
https://getsol.us
GNU General Public License v2.0
49 stars 16 forks source link

Fix: Endless update loop after pisi_callback error #231

Closed aventustudio closed 5 years ago

aventustudio commented 5 years ago

Under some circumstances, pisi_callback can receive an error signal which isn't handled by the function.

Example debug logs: https://pastebin.com/CTExQYvn

'reload_repos()' is called once variable 'is_updating' is set to True 'pisi_callback()' receives error signal 'invalidate_all()' won't be called variable 'is_updating' won't reset to False 'check_update_status()' will always quit early because 'is_updating == True'

Discussion: https://discuss.getsol.us/d/827-solus-budgie-update-notification/

aventustudio commented 5 years ago

Outdated fork