search

solusio / solusiovps

SolusIO WHMCS VPS Provisioning module
Apache License 2.0
23 stars 8 forks source link

SolusIO module intercepting upgrade orders #51

Open mrtimp opened 3 years ago

mrtimp commented 3 years ago

Hi there,

The AfterProductUpgrade hook in the hooks file:

https://github.com/solusio/solusiovps/blob/e97c096cc0780d484fbdca484ac79fa61cc8bd6e/hooks.php#L15-L17

seems to be intercepting all upgrades created via the client area even if they are for orders that do not relate to products using the SolusIO provisioning module and causing the following error:

1d6718ce-a722-4692-9e95-a7e60572a495

This functionality is currently blocking our ability to use this module as it blocks the ability to upgrade/downgrade other product types.

I'm picking a fix would be additional checking in WHMCS\Module\Server\SolusIoVps\WhmcsAPI\Product::upgrade to only perform the resize if the product uses the SolusIO provisioning module.

redikultsevsilver commented 3 years ago

Hi @mrtimp , thank you for the bug report.

I have submitted a a task to fix it in one of the upcoming releases as it looks like a blocker to me. Task ID is SIO-3409.

mrtimp commented 3 years ago

Thanks @redikultsevsilver, if you like once its resolved let me know and I'll update the version of the SolusIO module we use and do some functional testing :-)

acidmk commented 2 years ago

62

redikultsevsilver commented 2 years ago

Hi @mrtimp , we have released the new version of SolusIO vps module where the issue with module intercepting the upgrades should be fixed: https://github.com/solusio/solusiovps/releases/tag/v1.2.7

mrtimp commented 2 years ago

Thanks @redikultsevsilver