Feature/main 64 add form validation

solutionDrive / SyliusProductBundlesPlugin

Plugin for Sylius to configure bundles for products that can be sold together

MIT License

20 stars 4 forks source link

Feature/main 64 add form validation #35

Closed twojtylak closed 6 years ago

twojtylak commented 6 years ago

[ADDED] Display slot position input field
[ADDED] Form validation: Empty slot name or missing product association will throw an validation error
[ADDED] Display slot names in grid
[ADDED] 'Given channel ..' - background step for behat scenarios
[CHANGED] Use ProductAutocompleteChoiceType instead of ProductChoiceType for product bundle product
[CHANGED] Order slots (per default) by position (ASC)
[FIXED] Deleting of the presentation slot no longer causes deletion of product bundle

mattagohni commented 6 years ago

@twojtylak do you have any clue, why the build for php7.2 is broken?

twojtylak commented 6 years ago

@solutionDrive-Alt Not really. Selenium JS tests are always some kind of weird. But now the build is working. If the build breaks again after merging to master, I will add a flag the suites to prevent travis to execute this tests. The problem is described here StaleElement. I already try to select the elements, I'm working with, each time but sometimes the build on travis still breaks...