Updated to sylius/plugin-skeleton v1.3.6

solutionDrive / SyliusProductBundlesPlugin

Plugin for Sylius to configure bundles for products that can be sold together

MIT License

20 stars 4 forks source link

Updated to sylius/plugin-skeleton v1.3.6 #46

Closed anthid closed 5 years ago

mattagohni commented 5 years ago

First of all, thanks for your work. Looks great so far. If the phpstan-issues could be easily resolved, it would be awesome if we get it in this PR done.

anthid commented 5 years ago

At first sight looks like *|null typecasting divergences between docblocks and signature. Will take a look later today.

anthid commented 5 years ago

I have fixed the easy ones. There is still a couple of phpstan errors pointing to Symfony methods that aren't that self-evident to me. I will take a look in the coming days, but of course you can take a look in the meantime. :smile: