Closed solvaholic closed 3 years ago
Expose those ☝️ file paths as action outputs
I changed my mind, would like to do this step in a separate pull request. It's unnecessary for this feature and it'll require changes to entrypoint.sh
(and, therefore, the Docker image).
What changes are required for run local option?
None.
Provide example configs for different usage scenarios?
I added to README.md to cover available features.
I'll go ahead and merge this into main
. Manual tests went fine and the new feature is disabled by default.
@solvaholic are you planning on doing a new release with these changes or are you waiting until the feedback I had is addressed? Right now I'm pinning to a4b4942c255994ea2c6f193dfc472dec8093b219 and did my first deploy Friday. It worked great, thanks again for the great action.
fixes #35
How to test with the changes in this pull request
Use
solvaholic/octodns-sync@issue35
to run the changes pushed to branchissue35
:Add an
html
output to yourplan_outputs
in your octodns config, for example inpublic.yaml
:Configure your workflow to enable
add_pr_comment
and provide a token:To-do list
octodns-sync
log and plan output to two separate filesoctodns-sync
plan as a comment to the triggering pull request when:pull_request
add-pr-comment
is "Yes"