search

solvaholic / octodns-sync

GitHub Action to test and deploy DNS settings with OctoDNS
MIT License
28 stars 14 forks source link

Ubuntu-latest workflows will use Ubuntu-20.04 soon #46

Closed solvaholic closed 3 years ago

solvaholic commented 3 years ago

Description

Ubuntu-latest workflows will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816

Expected Behavior

Everything will be fine.

Actual Behavior

¯\_(ツ)_/¯

Possible Fix

Specify an Ubuntu release to use in workflows, rather than ubuntu-latest.

Steps to Reproduce

  1. Specify that a workflow runs-on: ubuntu-latest
  2. Trigger the workflow to run
  3. Observe the message in the run log

Context

It's been zero impact, except the ominous warning. Running -latest will probably continue to be fine.

Your Environment

solvaholic commented 3 years ago

I think none of this repository's workflows are impacted by the changes in https://github.com/actions/virtual-environments/issues/1816. So let's go ahead and specify 20.04, which should be supported for several years still.

% git grep ubuntu
.github/workflows/docker.yml:    runs-on: ubuntu-latest
.github/workflows/docker.yml:    runs-on: ubuntu-latest
.github/workflows/linter.yml:    runs-on: ubuntu-latest
.github/workflows/release.yml:    runs-on: ubuntu-latest
.github/workflows/sync-from-template.yml:    runs-on: ubuntu-latest