Not sure when this change happened, but in order to get the correct comments_url from GitHub, the proper environment name is github.event.pull_request.comments_url (note the extra .event).
Motivation and Context
This bugfix ensures that for a pull_request target, a comment is added again if add_pr_comment is set to Yet and pr_comment_token is set.
Without this fix the Action log wil mention something like this:
INFO: $ADD_PR_COMMENT is 'Yes' and $PR_COMMENT_TOKEN is set.
SKIP: $COMMENTS_URL is not set.
Was this workflow run triggered from a pull request?
With this fix, the expected result of a PR comment is achieved:
INFO: $ADD_PR_COMMENT is 'Yes' and $PR_COMMENT_TOKEN is set.
<Response [201]>
How Has This Been Tested?
I've tested this locally, and you can also test it by using uses: jasperroel/octodns-sync@main instead of uses: solvaholic/octodns-sync@main
Description
Not sure when this change happened, but in order to get the correct
comments_urlfrom GitHub, the proper environment name isgithub.event.pull_request.comments_url(note the extra.event).Motivation and Context
This bugfix ensures that for a
pull_requesttarget, a comment is added again ifadd_pr_commentis set toYetandpr_comment_tokenis set.Without this fix the Action log wil mention something like this:
With this fix, the expected result of a PR comment is achieved:
How Has This Been Tested?
I've tested this locally, and you can also test it by using
uses: jasperroel/octodns-sync@maininstead ofuses: solvaholic/octodns-sync@main