search

solvcon / devenv

Common development environment for solvcon
9 stars 17 forks source link

Hotfix/change cmake version #161

Closed xingularity closed 8 months ago

xingularity commented 9 months ago

Change Make version to 3.27.9

yungyuc commented 9 months ago

@chestercheng and @terrychan999 could you please help take a look?

yungyuc commented 9 months ago

@xingularity why 3.27.9 when 3.28.1 is available: https://www.kitware.com/cmake-3-28-1-available-for-download/ ?

terrychan999 commented 9 months ago

We can use the latest version if there are no breaking changes. Otherwise, everything looks good to me.

chestercheng commented 9 months ago

I’m not sure why it needs to specify that version, but the changes LGTM

yungyuc commented 9 months ago

Using specific version is generally more stable than using master/develop head

yungyuc commented 9 months ago

@xingularity when you finish the change please leave a global comment to request for review. No need to use the system button for it is not clear enough.

xingularity commented 8 months ago

@xingularity when you finish the change please leave a global comment to request for review. No need to use the system button for it is not clear enough.

In my latest commit, I have changed CMake version and corresponding hash to 3.28.1. I am now testing to build the environment. I will request for review, once I build Ok.

yungyuc commented 8 months ago

If the cmake version is working, we can merge the PR. Can you confirm?

xingularity commented 8 months ago

If the cmake version is working, we can merge the PR. Can you confirm?

The build of cmake is successful on Ubuntu Linux 22.04 and Mac.