search

solvcon / devenv

Common development environment for solvcon
9 stars 17 forks source link

fix bug in qt.d #167

Closed dragonwu0919 closed 2 weeks ago

dragonwu0919 commented 2 weeks ago

According to issue #166 , I comment the line 76 in qt.d and fix the bug of script.

https://github.com/solvcon/devenv/blob/ada270f51856644ea937581072eb8a43e5c54c84/scripts/build.d/qt#L76

dragonwu0919 commented 2 weeks ago

@yungyuc I have tried to fix issue166. Please help me review the code. Thank !!

ThreeMonth03 commented 2 weeks ago

It looks good to me.

yungyuc commented 2 weeks ago

@yungyuc I have tried to fix issue166. Please help me review the code. Thank !!

Thanks, @dragonwu0919 . This looks nice. @j8xixo12 , could you please help review?

j8xixo12 commented 2 weeks ago

Thanks @yungyuc, this change LGTM !