solvcon / devenv

Common development environment for solvcon
9 stars 17 forks source link

Incorrect qt version #169

Open xingularity opened 1 week ago

xingularity commented 1 week ago

The qt version in syncgit branch seems not up to date. https://github.com/solvcon/devenv/blob/8d71b499b68f47133fcc461dea020f54c4a5f92e/scripts/build.d/qt#L44

yungyuc commented 1 week ago

@dragonwu0919 do you have time to take a look?

dragonwu0919 commented 1 week ago

@dragonwu0919 do you have time to take a look?

Surely, but it may take some time for me to figure out how this script works.

ThreeMonth03 commented 1 week ago

The qt version in syncgit branch seems not up to date.

https://github.com/solvcon/devenv/blob/8d71b499b68f47133fcc461dea020f54c4a5f92e/scripts/build.d/qt#L44

Doesn't the old qt version support modmesh?

dragonwu0919 commented 1 week ago

@dragonwu0919 do you have time to take a look?

Surely, but it may take some time for me to figure out how this script works.

Looks like there are several releases on the web, the latest would be 6.6.3, 6.7.1 and 6.7.2. I don't know if there would be a dependency problem if I changed the script version directly to 6.7.2. I installed Qt 6.6.3 with online installer last month, and a dependency issue arouse due to incompatible version of Qt and PySide module.

I have seen that the version control of PySide is written in parameter form. But I don't know if there is a mechanism to align the version of Qt and PySide.

@ThreeMonth03 Do you known where and how qt and pyside6 are used while devenv functions?

yungyuc commented 1 week ago

The qt version in syncgit branch seems not up to date.

https://github.com/solvcon/devenv/blob/8d71b499b68f47133fcc461dea020f54c4a5f92e/scripts/build.d/qt#L44

@xingularity Please elaborate more for what you meant by "not up to date". It is hard for devenv scripts to closely track upstream releases, so I guess you did not mean to upgrade the script to use the latest qt release.

@terrychan999 for his awareness.

ThreeMonth03 commented 1 week ago

@dragonwu0919 do you have time to take a look?

Surely, but it may take some time for me to figure out how this script works.

Looks like there are several releases on the web, the latest would be 6.6.3, 6.7.1 and 6.7.2. I don't know if there would be a dependency problem if I changed the script version directly to 6.7.2. I installed Qt 6.6.3 with online installer last month, and a dependency issue arouse due to incompatible version of Qt and PySide module.

I have seen that the version control of PySide is written in parameter form. But I don't know if there is a mechanism to align the version of Qt and PySide.

@ThreeMonth03 Do you known where and how qt and pyside6 are used while devenv functions?

You could refer my notes about building modmesh on macOS. which aligns the version of qt6 and Pyside6 automatically. However, I never install pyside6 by devenv build pyside6 due to the bug in the script, so you may not deal with the pyside6 script temporarily.

BTW, I remember that the command devenv build qt only works on macOS. Although the qt script doesn't fail on ubuntu22.04; however, when running pip3 install pyside6==$(qmake6 -query QT_VERSION), the pyside6 package doesn't link to the qt library correctly, and I forget the reason why the installation fails. @chestercheng, do you remember that?

yungyuc commented 1 week ago

I never install pyside6 by devenv build pyside6 due to the bug in the script, so you may not deal with the pyside6 script temporarily.

Is the bug reported in the (devenv) github?

ThreeMonth03 commented 1 week ago

I never install pyside6 by devenv build pyside6 due to the bug in the script, so you may not deal with the pyside6 script temporarily.

Is the bug reported in the (devenv) github?

Not yet.

yungyuc commented 1 week ago

I never install pyside6 by devenv build pyside6 due to the bug in the script, so you may not deal with the pyside6 script temporarily.

Is the bug reported in the (devenv) github?

Not yet.

If it's hard to describe what happens in an issue, we can discuss here to clarify. It's also OK to create an issue and use it to discuss and clarify.

xingularity commented 6 days ago

The qt version in syncgit branch seems not up to date. https://github.com/solvcon/devenv/blob/8d71b499b68f47133fcc461dea020f54c4a5f92e/scripts/build.d/qt#L44

@xingularity Please elaborate more for what you meant by "not up to date". It is hard for devenv scripts to closely track upstream releases, so I guess you did not mean to upgrade the script to use the latest qt release.

@terrychan999 for his awareness.

Hi @yungyuc I should have explained more clear in this ticket. By “not up to date” meaning the two version in the script is not aligned and the one use syncgit is lagged behind. The other one in the same if else statement is using 6.6.3. This issue was meant to have a PR to fix it.

yungyuc commented 5 days ago

The qt version in syncgit branch seems not up to date. https://github.com/solvcon/devenv/blob/8d71b499b68f47133fcc461dea020f54c4a5f92e/scripts/build.d/qt#L44

@xingularity Please elaborate more for what you meant by "not up to date". It is hard for devenv scripts to closely track upstream releases, so I guess you did not mean to upgrade the script to use the latest qt release. @terrychan999 for his awareness.

Hi @yungyuc I should have explained more clear in this ticket. By “not up to date” meaning the two version in the script is not aligned and the one use syncgit is lagged behind. The other one in the same if else statement is using 6.6.3. This issue was meant to have a PR to fix it.

Thanks, @xingularity . @dragonwu0919 , do you think it is clarified or do you need more information on the request?

dragonwu0919 commented 5 days ago

The qt version in syncgit branch seems not up to date. https://github.com/solvcon/devenv/blob/8d71b499b68f47133fcc461dea020f54c4a5f92e/scripts/build.d/qt#L44

@xingularity Please elaborate more for what you meant by "not up to date". It is hard for devenv scripts to closely track upstream releases, so I guess you did not mean to upgrade the script to use the latest qt release. @terrychan999 for his awareness.

Hi @yungyuc I should have explained more clear in this ticket. By “not up to date” meaning the two version in the script is not aligned and the one use syncgit is lagged behind. The other one in the same if else statement is using 6.6.3. This issue was meant to have a PR to fix it.

Thanks, @xingularity . @dragonwu0919 , do you think it is clarified or do you need more information on the request?

@yungyuc My understanding of the current situation is that the version of a particular module (6.5.3) is behind the versions of other modules in devenv (6.6.3). If my understanding is correct, I can try opening a PR to change pkgbranch=${VERSION:-6.5.3} to pkgbranch=${VERSION:-6.6.3}.