search

solvcon / modmesh

Toolkit for solving partial differential equations
BSD 3-Clause "New" or "Revised" License
38 stars 38 forks source link

Adjust the boundary to improve the plotting #335

Open Gene0315 opened 4 months ago

Gene0315 commented 4 months ago

PR #330 implemented new boundary treatment. However, apart from revising the NRBC method, it is also a nice way to make some other adjustments to improve the plotting. For instance, add a half dx grid point outside the boundary and not show it on the figure.

yungyuc commented 4 months ago

@j8xixo12 This may be an opportunity to give the Euler 1D app a better architecture and absorb it into proper places in the GUI. What do you think?

j8xixo12 commented 4 months ago

@yungyuc Since modmesh has mesh viewer which is able to read Gmsh and Plot3d mesh file and a Euler 1D solver. I think it's time to re-design the GUI!

But currently I have no idea how to design the new GUI. If the GUI should be designed based on a numerical analysis workflow, where the user first loads the mesh, then sets up the solver configuration likes boundary condition and convergence criteria...etc and then runs the simulation, these steps are guided by GUI. Or should it be divided by functionality, with each button corresponding to a specific function. I think this design is similar to the current design of modmesh, but it seems like lacking in integration. the previous design more like... Ansys workbench!

yungyuc commented 4 months ago

@j8xixo12 I outlined some ideas in https://github.com/solvcon/modmesh/discussions/336 . At this stage, the key is to organize what we had in the proof-of-concept "Apps", and make the "Apps" a clear plugin system.

I am not sure how Ansys workbench looks like, and certainly did not reference it. In my vision, the GUI will be an integrated problem-solving environment. We will need to give it a cool name once putting it back to the mother solvcon code base.

yungyuc commented 3 months ago

@Gene0315 plans to update https://github.com/solvcon/modmesh/pull/338#issuecomment-2147920131 by 8th June. We will review then.

yungyuc commented 2 months ago

@Gene0315 is there any progress made for this enhancement request?

Gene0315 commented 2 months ago

@Gene0315 is there any progress made for this enhancement request?

I failed to add the variable which represents the grid index shown in the figure. I created a PR in my repo to try to add it successfully, but I’ve not solved it yet. I don't know how to get more detail error messages in the VSCODE.