solvcon / modmesh

Toolkit for solving partial differential equations
BSD 3-Clause "New" or "Revised" License
29 stars 35 forks source link

add gtest for ConcreteBuffer, SimpleArray and BufferExpander #358

Closed tigercosmos closed 3 weeks ago

tigercosmos commented 3 weeks ago

This PR aims to close https://github.com/solvcon/modmesh/issues/306.

p.s. Seems that SimpleCollector.hpp also misses the implementation of iterator, but let's make it in another PR.

yungyuc commented 3 weeks ago

This PR aims to close #306.

I am not sure using the PR directives like "close", "fix" is a good idea. But let's try. If we need to do a lot of manual reopen, maybe it's not good.

p.s. Seems that SimpleCollector.hpp also misses the implementation of iterator, but let's make it in another PR.

Makes sense.

tigercosmos commented 3 weeks ago

@yungyuc do you think the issue is not ready to close after this PR? also, please check my comment.