Closed tigercosmos closed 3 weeks ago
This PR aims to close #306.
I am not sure using the PR directives like "close", "fix" is a good idea. But let's try. If we need to do a lot of manual reopen, maybe it's not good.
p.s. Seems that
SimpleCollector.hpp
also misses the implementation of iterator, but let's make it in another PR.
Makes sense.
@yungyuc do you think the issue is not ready to close after this PR? also, please check my comment.
This PR aims to close https://github.com/solvcon/modmesh/issues/306.
ConcreteBuffer
, I think we don't need to align the iterator implementation betweenConcreteBuffer
andBufferExpander
. InConcreteBuffer
, there are nom_begin
andm_end
, and only has astd::unique_ptr<int8_t, data_deleter_type>
typem_data
, so I think we can keep it as it is.ConcreteBuffer
,SimpleArray
, andBufferExpander
.p.s. Seems that
SimpleCollector.hpp
also misses the implementation of iterator, but let's make it in another PR.