solvcon / modmesh

Toolkit for solving partial differential equations
BSD 3-Clause "New" or "Revised" License
29 stars 35 forks source link

Add items under "mesh" menu #360

Closed yungyuc closed 3 weeks ago

yungyuc commented 3 weeks ago

For issue #324

Update the following items under "mesh" menu:

Add the following items under the menu. They are migrated from the module "modmesh.app.sample_mesh":

image

The new code is in the Python modules modmesh.gui.sample_mesh and modmesh.gui.naca.

A new C++ Qt class modmesh::RPythonAction is added for the menu items.

yungyuc commented 3 weeks ago

The coding style and encapsulation are decent,

but the example is not easy to read.

No. They are not easy to read. They are supposed to be viewed in the viewer.

yungyuc commented 3 weeks ago

I am going to merge. @j8xixo12 feel free to ask for modification. I will address in a future PR.