search

solvcon / modmesh

Toolkit for solving partial differential equations
BSD 3-Clause "New" or "Revised" License
38 stars 38 forks source link

SerializableItem: implement JSON from string #377

Closed tigercosmos closed 3 months ago

tigercosmos commented 3 months ago

Support JSON from string

tigercosmos commented 3 months ago

@yungyuc

Use STL isalpha, isdigit, is_integral, and is_floating_point.

all fixed.

Do not alias smart pointer types.

fixed.

Use the modern using syntax.

fixed.

Clarify how to improve the output argument of from_json_string().

output argument is needed by design.

from_json_string() is too long for class declaration.

splitted.

All issues are addressed, please also check the comments.

tigercosmos commented 3 months ago

@yungyuc please see my comment here: https://github.com/solvcon/modmesh/pull/377#discussion_r1653774032

tigercosmos commented 3 months ago

@yungyuc comments for the output argument is added.

yungyuc commented 3 months ago

I saw the change and will merge once CI completes.