Open j8xixo12 opened 2 weeks ago
Improvement of the gmsh reader can be considered with issue #424.
@j8xixo12 could you please make a check-list for all the improvements listed in #429 ?
Check-list for all the improvements in #429
bool Gmsh::is_valid_transition(const std::string s)
constexpr
for the version number.emplace
in https://github.com/solvcon/modmesh/blob/180e91122977d6a75d3c0cc6935cd744f0edf22a/cpp/modmesh/inout/gmsh.hpp#L211void
in function declaration.Could you please copy the check list to the issue description (by editing it)? It will be easier to track.
Could you please copy the check list to the issue description (by editing it)? It will be easier to track.
No problem !
Thanks @tigercosmos to point out this issue in https://github.com/solvcon/modmesh/pull/429/files#r1788654979
The logic of paring physical names section and nodes section has a defect, that need to be fixed.
Before closing this issue, the following item should be finish:
bool Gmsh::is_valid_transition(const std::string s)
constexpr
for the version number.emplace
in https://github.com/solvcon/modmesh/blob/180e91122977d6a75d3c0cc6935cd744f0edf22a/cpp/modmesh/inout/gmsh.hpp#L211void
in function declaration.