Add support for php5.6 - Githubissues

solvecrew / ExpoNotificationsBundle

Symfony bundle to handle the BE parts of the push notifications from the expo react-native framework.

MIT License

20 stars 17 forks source link

Add support for php5.6 #14

Closed lauzel closed 6 years ago

lauzel commented 6 years ago

Hello,

First of all, very good work. This bundle is very well designed.

My environment restricts me to using php5.6.

That's why I bring php5.6 support through this PR.

Being relatively new to github, I couldn't create a php5.6 branch on your repository. I think it would be better to create a separate branch to support this version of php.

Any criticism is of course welcome !

Thanks !

solvecrew commented 6 years ago

Great you're here! I merged your changes into the php56 branch i just forked from the develop.

solvecrew commented 6 years ago

Since Changes are merged, I close this PR.