SafeButNotConsensualMutators removes call to this() in constructor

[thungsten]

If we apply SafeButNotConsensualMutators to our sources, all calls of this(); inside a constructor are removed. This shouldn't be considered a safe operation, because other constructors may call the "empty" default constructor to initialise an object properly.

Example: Gradle Configuration

spotless {
  java {
    cleanthat()
      .sourceCompatibility('11')
      .addMutator('SafeAndConsensual')
      .addMutator('SafeButNotConsensual')
      .includeDraft(false)
  }
}

Java Source Code

class Horse {
  private String sound;
  private String name;

  Horse() {
    // here it is a static assignment
    // however, this might be fetched from any other class
    sound = "neigh neigh";
  }

  Horse(String name) {
    this(); // <-- this is removed if applying "SafeButNotConsensualMutators"
    this.name = name;
  }

  Horse(String name, String sound) {
    this.name = name;
    this.sound = sound;
  }  
} 

[blacelle]

Hello. This should be fixed in CLeanthat 2.19: https://github.com/solven-eu/cleanthat/issues/804

[blacelle]

@thungsten Have you been able to confirm the fix works for you?