search

solven-eu / cleanthat

Github App opening automatically cleaning PR
56 stars 16 forks source link

Fix issues affecting UnnecessaryModifier #844

Closed mches closed 1 week ago

mches commented 1 week ago

Fixes issues #842 and #843 affecting UnnecessaryModifier

blacelle commented 1 week ago

I changed CircleCI to kicks-in on forked-PRs. Let's force merge this for now.

Thanks a lot @mches ! Feel free to reach for additional feedback/request/ideas.

mches commented 1 week ago

It's my pleasure. For UnneccessaryModifier, I would say removing public, static, and final from a nested record would be in order. The first time around I didn't notice @CompareCompilationUnitsAsResources to overcome the language level, otherwise I would have added it all at once.