solvuu / phat

Strongly typed file path and file system operations.
ISC License
26 stars 4 forks source link

`normalize` should normalize link targets #14

Closed agarwal closed 8 years ago

agarwal commented 8 years ago

I can't remember if this was previously discussed, but our current normalize doesn't normalize link targets. I feel like it should. The benefits would be:

On a related note, we should avoid the wildcard pattern in equal_normalized. It would be only 1 more line of code to be explicit.

Once this is done, we should include Comparable.Make.

pveber commented 8 years ago

I implemented compare, but I think using Comparable.Make is not possible due to type parameter in Path.t. Only possibility would be to provide the four variants, should I do it?

agarwal commented 8 years ago

Four variants isn't ideal. Let's hold on this.

agarwal commented 8 years ago

Let's decide to not call Comparable.Make. Users can call themselves for now in the cases they need it. So closing this issue.