search

solvuu / solvuu-build

DEPRECATED. We recommend Jane Street's dune (formerly jbuilder).
ISC License
24 stars 5 forks source link

libs with multiple directories #49

Closed agarwal closed 7 years ago

agarwal commented 7 years ago

Allow the files for a single library to be placed in multiple directories.

tekknolagi commented 7 years ago

How is progress on this?

agarwal commented 7 years ago

I'll work on this in the next couple of days.

tekknolagi commented 7 years ago

Awesome.

agarwal commented 7 years ago

I pushed a fix to a new branch issue-49. It would be great if I could get confirmation that it works for others. I tested on one project and it seems okay to me.

tekknolagi commented 7 years ago

@agarwal how should I test it? Docs?

agarwal commented 7 years ago

You'll have to pin to that branch with something like opam pin add solvuu-build https://github.com/solvuu/solvuu-build.git#issue-49. Then simply use as usual but the dir used to create a lib should include sub-directories.

Do you have an existing repo you're trying it on? I just wanted validation it works for your specific use case, but that is moot if you would be trying solvuu-build for the first time.

tekknolagi commented 7 years ago

@agarwal Yes, but it did not previously use solvuu-build. There was an attempt, which ended after the realization that it did not handle multiple directories.

agarwal commented 7 years ago

I went ahead and merged 647393d02999d03258f5951422691cf85178109b to master. Please ask more questions if it is unclear how to use it, but I'll close this issue for now.