solvvy / redact-pii

Remove personally identifiable information from text.
MIT License
189 stars 57 forks source link

Please include information on your page that this is only meant for NodeJs. #77

Open kenlnetherland opened 6 months ago

kenlnetherland commented 6 months ago

This may work in browsers if you install "tons" of polyfills. But this is not indended for browers as you advertise.

dennybiasiolli commented 6 months ago

@kenlnetherland is this text at the beginning of the README file not enough?

Prerequesites This library is primarily written for node.js but it should work in the browser as well. It is written in TypeScript and compiles to ES2017. The library makes use of async functions and hence needs node.js 8.0.0 or higher (or a modern browser). If this is a problem for you please open an issue and we may consider adapting the compiler settings to support older node.js versions.

kenlnetherland commented 6 months ago

Thanks for responding. I tried using it with Angular but kept getting errors with the npm packages that are strictly NodeJs packages. Your code may work, but the dependencies do not. My node version: v18.19.1

@angular-devkit/architect 0.1602.12 @angular-devkit/build-angular 16.2.12 @angular-devkit/core 16.2.12 @angular-devkit/schematics 16.2.12 @nguniversal/builders 16.2.0 @nguniversal/express-engine 16.2.0 @schematics/angular 16.2.12 ng-packagr 16.2.3 rxjs 7.5.0 typescript 4.9.5 zone.js 0.13.3

dennybiasiolli commented 6 months ago

Well, it works in our company Vue.js 2 project directly in the browser, but we forked the repo in order to remove the @google-cloud/dlp dependency that we are not using, and adding a couple of improvements.

Forked repo here: https://github.com/Fingerprint-Compliance/redact-pii Changelog:

4.0.0 - 2021-09-09

  • BREAKING CHANGE: removing @google-cloud/dlp dependency
  • Improvement: adding lib directory to git, in order to use this library as is, in the compiled version
  • Fix: improving regex pattern including dashes in email domain addresses
  • Fix: improving url regex in href links