Filter subject selector on exams page

solymosi commented 7 years ago

Original idea and implementation by @whisperity: #7 Related discussion: #5

Fixes and enhancements:

Remove $.examSubjectFilterValid, use $.examSubjectFilterCache === null to signal an invalid or nonexistent filter cache.
Extract subject code parsing code from courses page to npu.parseSubjectCode and reuse it to parse subject code out of the subject selector on the exams page, instead of matching for substrings. This parsing code has already been battle-tested and properly handles even weird subject codes with (s and )s in them.
Simplify logic for determining the class to add, and the logic that adds classes to <option>s.
Remove cache invalidation when "completed exam filtering" is toggled, as my tests revealed that we don't need it.
Adjust logic in npu.initExamAutoList to work with the updated code in fixExamList.

solymosi commented 7 years ago

@whisperity can you please review this PR and test it in your browser / Neptun? Thanks!

whisperity commented 7 years ago

It looks good for me, I see all my subjects (though being in the end of the semester I really don't see that many rows) and tested it with a few of my friends' accounts.

There is one BIG problem though. My original idea was that if I select Hide completed subjects, the green rows from the select also disappear, which does not happen right now in my tests.

solymosi commented 7 years ago

Oops, my bad. Should be fixed in https://github.com/solymosi/npu/pull/11/commits/564fb924a6becbb6f8da161680e4401817ac3e27

solymosi commented 7 years ago

Thanks a lot, merging...

solymosi commented 7 years ago

Release complete 🎉

solymosi / npu

Filter subject selector on exams page #11