search

solymosi / npu

Neptun PowerUp! - Felturbózza a Neptun-odat
MIT License
274 stars 47 forks source link

Explicit check for passing grades #22

Closed solymosi closed 6 years ago

solymosi commented 6 years ago

Should fix #21

@whisperity Can you please test this on the exam registration page? I don't have access to any Neptun accounts that have subtables with previous attempts on that page.

You can test multiple scenarios by manually changing the grade string in the table cell using the developer tools and then removing the data-processed tag from the outer table, at which point the styles will be recalculated. Please if you can, test with both pass, fail and unrecognized marks.

This might also fix the other bug you mentioned in #21.

whisperity commented 6 years ago

Unfortunately, neither do I. But in the middle of the exam periods, I'll be. :grin:

solymosi commented 6 years ago

I'll send the OP of #21 a pre-release version and ask whether it fixes their particular problem.

If the script doesn't misbehave in their case, let's release it, as this bug could cause users to miss exams, and I'd rather have a broken feature than that.

solymosi commented 6 years ago

The fix seems to be working for the OP. I'll release it.