search

solymosi / npu

Neptun PowerUp! - Felturbózza a Neptun-odat
MIT License
274 stars 47 forks source link

Fix consistency issues of exam coloring and filtering feature #3

Closed solymosi closed 8 years ago

solymosi commented 8 years ago

Entirely overriding the way Neptun lists and displays exams resulted in inconsistent behavior and random bugs in Firefox under certain circumstances (slow page load, changing terms too quickly). This PR does its best to provide as much of the new functionality as possible, while keeping the number of internal changes to a minimum, which results in more reliable and future proof behavior.

whisperity commented 8 years ago

:smile: Everything works fine apart from the obviously removed features.

solymosi commented 8 years ago

Thanks for testing. Merging and releasing...

whisperity commented 8 years ago

I think this PR should be merged and the stripped code should go live, as in the one that gets installed and updated for the users, along with a slight version number increase.

I will do my best to quickly find a new solution for the filtering to work properly and then we could go v1.5 :wink:

solymosi commented 8 years ago

Sounds good, although that major version will have to be 1.50.0. We have a weird versioning system... :confused:

solymosi commented 8 years ago

The release is complete. You have been credited on the project's website: https://secure.solymosi.eu/blog/neptun-powerup/ Let me know on the off chance you are uncomfortable with your nick being present there.

whisperity commented 8 years ago

There's a slight misunderstanding on that page concerning the exam list:

"A szkript módosít néhány színt az oldalon, hogy jobban lásd az egyes vizsgák állapotát. Az először felvett vizsgák sárga hátteret, [...]"

And in the changelog:

"Az először felvett vizsgák továbbra is sárga színnel jelennek meg. [...]"

These say that only the first subscribed exam from a subject is presented in yellow while AFAIK (can't test it now, my semester is already finalised) every subscribed exam should be yellow from the gridrow_blue class added by Neptun itself.

Or was the script altered due to an oversight in the development process? I think this latter one is the case, I will make sure to "fix" this. It's more important to see which exam you are still to take alongside the other possible exams you could attend than see if the subjects is already passed or not, considering, for example, exam retakes for a better mark.

whisperity commented 8 years ago

@solymosi Could you write my name with a capital first letter? Other than that, it is fine. :gem:

solymosi commented 8 years ago

@whisperity Thanks, fixed