search

solymosi / npu

Neptun PowerUp! - Felturbózza a Neptun-odat
MIT License
274 stars 47 forks source link

Store latest supported Neptun version in a script variable, show a bit of warning on login page if higher #30

Closed whisperity closed 3 years ago

whisperity commented 6 years ago

Example ELTE: image

BME: image

solymosi commented 6 years ago

I like this idea, it also shouldn't be very hard to implement :+1:

The wording of the warning message is crucial, because we need it to be actionable. We can't just say, "this version is not guaranteed to be compatible" because the average user won't know what to do about that. Instead, we should instruct the user to check the NPU homepage for updates, and leave a comment about the new Neptun version if there aren't any updates. We also need to tell them that they might need to temporarily disable the script if it breaks the operation of Neptun in a severe way.

If v2.0 ever gets implemented (see https://github.com/solymosi/npu/issues/12), we can go even further and introduce the ability to mark the Neptun version compatibility of individual modules. That way we could have multiple modules implementing the same feature, each with a different compatibility setting, and the system would use the one that matches the Neptun version of the university in question.

whisperity commented 4 years ago

It seems the versioning scheme officialy has changed.

ELTE: image

BME: image

whisperity commented 3 years ago

Aaaand shit... the new ELTE homepage basically side-steps the Neptun log-in logic, and there isn't any page anymore where the version string is available.

BME is still going strong, and they are using: Verzió: 2020.3.33 (2021. 02. 02.)

solymosi commented 3 years ago

@whisperity Yeah, I also noticed 😕

In general I'm not convinced that such a warning would bring too much benefit. It would mean that we'd have to keep re-testing the script on each new version of Neptun and bumping the version number in the script, even though major changes that would break the script are very rare: in August the script will be 10 years old and e.g. most of the original course registration UI enhancements have survived just fine ever since.

whisperity commented 3 years ago

Yeah, let's scrap this... Only one thing broke once, the already taken exams page, or something like that, I remember fixing a few years ago.